Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/factorio: sandbox service using systemd #60670

Merged
merged 1 commit into from May 17, 2019
Merged

nixos/factorio: sandbox service using systemd #60670

merged 1 commit into from May 17, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented May 1, 2019 •
edited

  • DynamicUser enabled instead of static uid/gid
  • Enables most sandboxing options systemd offers
Motivation for this change

Tested on my system without problems

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

@nyanloutre could you rebase this on current master please?

@nyanloutre
nixos/factorio: sandbox service using systemd
85b3448 
- DynamicUser enabled instead of static uid/gid
- Enables most sandboxing options systemd offers
@nyanloutre
Copy link
Member Author

@c0bw3b done

@c0bw3b
Copy link
Contributor

c0bw3b commented May 17, 2019

Thanks!

@c0bw3b c0bw3b merged commit c5fd2a4 into NixOS:master May 17, 2019
@nyanloutre nyanloutre deleted the factorio_sandbox branch May 17, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @c0bw3b