Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gitea: Unbreak the gitea-dump module #60669

Closed
wants to merge 1 commit into from

Conversation

etu
Copy link
Contributor

@etu etu commented May 1, 2019

Motivation for this change

It tries to create /nix/store/hash-gitea/bin/custom when executed if
we don't define which directory to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It tries to create /nix/store/hash-gitea/bin/custom when executed if
we don't define which directory to use.
@etu etu mentioned this pull request May 1, 2019
10 tasks
@etu
Copy link
Contributor Author

etu commented May 1, 2019

I tested this change by adding systemd.services.gitea-dump.environment.GITEA_CUSTOM = "${config.services.gitea.stateDir}/custom"; to my production gitea system that still runs on 18.09 where it's also dead.

@etu etu added 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. labels May 1, 2019
@ofborg ofborg bot added the 6.topic: nixos label May 1, 2019
@etu etu requested a review from aanderse May 1, 2019 20:51
@aanderse
Copy link
Member

aanderse commented May 1, 2019

@etu how do I reproduce the problem? I'm running gitea 1.8 with the 19.03 module and the dumps appear to be working.

@etu
Copy link
Contributor Author

etu commented May 1, 2019

Hmm, you're right... It works on my 19.03 (I was mostly worried about my 18.09 that I need to migrate off because it's broken there).

@etu etu closed this May 1, 2019
@etu etu deleted the unbreak-gitea-dump branch May 1, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants