Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: nixos/cron: force restart when the declarative crontab has changed #60650

Closed
wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented May 1, 2019

Motivation for this change

WIP: do not merge

NixOS doesn't restart cron when make changes to services.cron.systemCronJobs.

As a test case you could create a cronjob like so and deploy:
services.cron.systemCronJobs = [ "* * * * * root echo test_1" ];
Change to this and deploy:
services.cron.systemCronJobs = [ "* * * * * root echo test_2" ];

Note that the cron service is not reloaded. The first time after you have deployed the second cronjob it will execute the first cronjob, and then subsequent executions will be correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse changed the title nixos/cron: force restart when the declarative crontab has changed WIP: nixos/cron: force restart when the declarative crontab has changed May 2, 2019
@aanderse aanderse closed this May 2, 2019
@aanderse aanderse deleted the nixos/cron branch May 5, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants