Pharo VM (64b) for Pharo 7 and Pharo 8 images #60649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to fix the automated checks. |
|
Great work! |
rydnr
requested review from
alyssais,
basvandijk,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
joachifm,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
Profpatsch,
thoughtpolice,
ttuegel and
zimbatm
as code owners
|
Please rebase this on nixpkgs master. |
ofborg
bot
added
6.topic: erlang
6.topic: GNOME
the old hash was for 2.0.5, so the store path for the dist-info was: /nix/store/v5sgpkxpp950chzdzzj4b5yl9r0w0by7-python3.7-Flask-Script-2.0.6/lib/python3.7/site-packages/Flask_Script-2.0.5.dist-info
Removes QuickChick for Coq 8.7 as it is broken (probably due to a too recent ssreflect).
The error can be reproduced like:
```
$ nix-instantiate ./nixos -A system --arg configuration '
{ fileSystems."/".device = "nodev";
boot.loader.grub.devices = [ "nodev" ];
containers.t.config.imports = [ <nixpkgs/nixos/modules/virtualisation/amazon-image.nix> ];
}'
```
Previously error was:
```
error: The unique option `containers.t.networking.hostName' is defined multiple times, in `/nix/var/nix/profiles/per-user/root/channels/nixpkgs/nixos/modules/virtualisation/amazon-image.nix' and `module at /home/danbst/dev/nixpkgs/nixos/modules/virtualisation/containers.nix:470'.
(use '--show-trace' to show detailed location information)
```
Now it is:
```
error: The unique option `containers.t.networking.hostName' is defined multiple times, in:
- /nix/var/nix/profiles/per-user/root/channels/nixpkgs/nixos/modules/virtualisation/amazon-image.nix
- module at /home/danbst/dev/nixpkgs/nixos/modules/virtualisation/containers.nix:470.
(use '--show-trace' to show detailed location information)
```
Related: #15747
See #15747. Previously this module was called `<unknown-file>` in error messages, now it is called a bit more close to real: ``` module at /home/danbst/dev/nixpkgs/nixos/modules/virtualisation/containers.nix:470 ```
not all valid file names are valid derivation names. This can cause troubles when, for example, trying to place systemd template unit files, which contain an '@' in their name, in an initrd. Fixes #53987
This reverts commit 35af6e3.
This downgrade is needed temporarily to alleviate breakages such as [0] to Pantheon on Unstable. [0]: elementary/gala#518
This hook allows to add NixOS driver libraries path to given ELF objects' RUNPATH. We use it instead of settings RUNPATH manually everywhere. It must be invoked in postFixup so that RUNPATH stripping does not remove the path. It puts the path first instead of last so that system-wide drivers are always preferred.
`updateScript` lets us update packages automatically. For packages that are hosted on the gnome mirror it's very easy to add that. Inspired by #36150
* Install required tool dependencies ('tar', 'rdiff', etc.)
* Run installed duplicity instead of source tree duplicity
* Fix shebang of scripts in testing/overrides/bin/
* Disable some unhelpful developer-only tests
* Disable a test broken on Linux (root cause unknown)
* Work around low file descriptor soft limit for Darwin builders
|
Any updates on this? |
|
I created another PR: #66387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Current Pharo package (specifically, spur64) contains a Smalltalk VM that doesn't work correctly with Pharo 7 and Pharo 8 images. It shows a blank screen. Also, some recent Pharo distributions (such as GToolkit https://github.com/feenkcom/gtoolkit) require libmoz2d to be installed.
This PR includes the work from @lukego for spur64. For 32b there's still some work to be done, so it's left as is.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)