Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-jsonnet: init at v0.13.0 #60529

Merged
merged 1 commit into from Jun 6, 2019
Merged

go-jsonnet: init at v0.13.0 #60529

merged 1 commit into from Jun 6, 2019

Conversation

nshalman
Copy link
Member

@nshalman nshalman commented Apr 30, 2019 •
edited

Motivation for this change

The go version of jsonnet is faster at compiling. It's nice to have it as an option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes May 5, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add all meta (license, description, ...) information.

pkgs/development/compilers/go-jsonnet/default.nix Outdated Show resolved Hide resolved
@nshalman
Copy link
Member Author

nshalman commented May 5, 2019

You also need to add all meta (license, description, ...) information.

Thanks for the review. I've updated this PR accordingly.

nlewo
nlewo requested changes May 7, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to become the maintainer of this package? In this case, you could add yourself in the maintainer list.

pkgs/development/compilers/go-jsonnet/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/go-jsonnet/default.nix Outdated Show resolved Hide resolved
@nshalman
Copy link
Member Author

nshalman commented May 7, 2019

Would you like to become the maintainer of this package? In this case, you could add yourself in the maintainer list.

Only if I have to...

@nlewo
Copy link
Member

nlewo commented May 11, 2019

It's not mandatory for a package to have a maintainer but it's really better! If you are the maintainer, it is easier for you to do upgrades because we merge more quickly upgrades from maintainers. You are also notified on upgrades.
So, it's up to you ;)

@nshalman nshalman mentioned this pull request May 13, 2019
Closed
@nshalman
Copy link
Member Author

I'm going to wait for upstream to cut a new release and point to that tag. I'll add myself as a maintainer at the same time.

@nshalman nshalman changed the title go-jsonnet: New package v0.12.1 go-jsonnet: New package v0.13.0 Jun 5, 2019
@nshalman
Copy link
Member Author

nshalman commented Jun 5, 2019

@nlewo Upstream has tagged a new release, and I've updated this PR accordingly. Please review again when you have a moment.

@nshalman nshalman changed the title go-jsonnet: New package v0.13.0 go-jsonnet: init at v0.13.0 Jun 5, 2019
@nlewo
Copy link
Member

nlewo commented Jun 6, 2019

@GrahamcOfBorg build go-jsonnet

@nlewo
Copy link
Member

nlewo commented Jun 6, 2019

Thx!

@nlewo nlewo merged commit b35c1d4 into NixOS:master Jun 6, 2019
@nshalman nshalman deleted the go-jsonnet branch June 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nshalman @nlewo