Add support for Epson network scanners #60568
Conversation
|
I've tested it based on release-19.03. I don't have a setup with master to validate cherry-pick works on master. Is there a procedure to validate a patch against master except by upgrading to master? For a separate standing packages it's easy to install it with nix-env but this package involves configuration options and I am not yet sure how to build with options included but isolated from the host. |
|
Clone another copy of the |
|
@risicle I can definitely build the package but it's hard to tell if it definitely works with the whole setup (sane config files etc.) unless I build the whole system using master and the PR and try it out. |
|
You can take a simple (or complex) machine configuration and build a vm from it https://nixos.wiki/wiki/Cheatsheet#Reuse_a_package_as_a_build_environment which you can just launch with a single command. |
|
@risicle these build tools are amazing! I've just built a VM with my configuration and this branch (that is based on master) and validated that |
|
/assign @symphorien |
|
Looks good to me! |
|
@symphorien thanks for checking. How do we get it merged? I believe you are marked as the package maintainer so I hoped you can nudge it in. |
|
Sorry, I don't have merge rights. We can only wait for someone who can to notice this PR. |
| ntPluginVersion = "1.1.1-1"; | ||
|
|
||
| buildInputs = [ stdenv.cc.cc.lib ]; | ||
| nativeBuildInputs = [ autoPatchelfHook ]; |
There was a problem hiding this comment.
If this works then, perhaps, other plugins could use this too.
No description provided.