Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyfakefs: fix build #60566

Merged
merged 1 commit into from May 1, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 1, 2019

Motivation for this change

pyfakefs recently changed the test path pytest-dev/pyfakefs@4b4e594

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 1, 2019

@GrahamcOfBorg build pythonPackages.pyfakefs

@gebner gebner merged commit 4bcb003 into NixOS:master May 1, 2019
@marsam marsam deleted the fix-build-pythonPackages.pyfakefs branch May 1, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants