Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: 0.3.5 -> 0.3.6 #60573

Merged
merged 1 commit into from May 17, 2019
Merged

openblas: 0.3.5 -> 0.3.6 #60573

merged 1 commit into from May 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 1, 2019

Motivation for this change

https://github.com/xianyi/OpenBLAS/releases/tag/v0.3.6

We probably no longer need to explicitly disable AVX512 support (#60092)
but it doesn't hurt so leaving it as-is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel May 1, 2019 03:39
@markuskowa
Copy link
Member

@dtzWill Let's leave the AVX512 in for now. How the new version runs with and without the patch.
@GrahamcOfBorg build scalapack
@GrahamcOfBorg build python37.numpy

@FRidh
Copy link
Member

FRidh commented May 4, 2019

@GrahamcOfBorg build python3.pkgs.numpy

@markuskowa markuskowa mentioned this pull request May 17, 2019
Closed
10 tasks
@nh2 nh2 mentioned this pull request May 17, 2019
Merged
11 tasks
@matthewbauer matthewbauer merged commit 2de2bc4 into NixOS:staging May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @markuskowa @FRidh @matthewbauer