Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: add gettext #60570

Merged
merged 1 commit into from May 1, 2019
Merged

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Needed on libc without gettext bundled.

Fixes NixOS#11420
@CrazedProgrammer
Copy link
Contributor

Looking at the commits, are you sure you didn't accidentally merge a wrong branch?

@matthewbauer matthewbauer changed the base branch from staging to master May 1, 2019 15:39
@matthewbauer matthewbauer changed the base branch from master to staging May 1, 2019 15:39
@matthewbauer
Copy link
Member Author

Yeah github bug. It only refreshes the base commit when you change base branches.

@ofborg ofborg bot removed 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: ruby 8.has: module (update) labels May 1, 2019
@ofborg ofborg bot requested a review from Ericson2314 May 1, 2019 15:57
@matthewbauer matthewbauer merged commit 9dfd52c into NixOS:staging May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants