Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.papis: fix build by disabling over-specific yaml output tests #60674

Merged
merged 1 commit into from May 7, 2019
Merged

pythonPackages.papis: fix build by disabling over-specific yaml output tests #60674

merged 1 commit into from May 7, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 1, 2019

Motivation for this change

The tests in question will fail when built against pyyaml 5.x, an issue which appears to have been addressed upstream but not released yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.papis: fix build by disabling over-specific yaml outpu…
9efddf7 
…t tests

these tests will fail when built against pyyaml 5.x, an issue which
appears to have been addressed upstream but not released yet.
@risicle risicle requested a review from FRidh as a code owner May 1, 2019 21:28
@ofborg ofborg bot requested a review from teto May 1, 2019 22:13
@teto
Copy link
Member

teto commented May 2, 2019

A release to papis should be pretty close, there is only one PR left. Once we merge this, we will need to revert it afterwards. meanwhile people can disable the checkPhase in overlays. Not sure what to do.

@worldofpeace
Copy link
Contributor

I think that even disabling or fixing the tests on unstable in this situation is fine because it doesn't take too much effort.

@worldofpeace worldofpeace merged commit 178605a into NixOS:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @teto @worldofpeace