Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-bug: 0.4.0 -> 0.5.0 #60677

Merged
merged 3 commits into from May 3, 2019
Merged

gitAndTools.git-bug: 0.4.0 -> 0.5.0 #60677

merged 3 commits into from May 3, 2019

Conversation

royneary
Copy link
Contributor

@royneary royneary commented May 1, 2019 •
edited

Motivation for this change

Update to version 0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam reviewed May 3, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like git-bug vendorizes its dependencies, hence ./deps.nix is not needed, would you mind removing it? besides that, LGTM

@marsam
Copy link
Contributor

marsam commented May 3, 2019

@GrahamcOfBorg build gitAndTools.git-bug

@marsam marsam merged commit 14fa46a into NixOS:master May 3, 2019
@marsam
Copy link
Contributor

marsam commented May 3, 2019

built and tested locally on NixOS and darwin
@royneary thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@royneary @marsam