Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evcxr: init at 0.3.3 #60675

Merged
merged 4 commits into from Jul 21, 2019
Merged

evcxr: init at 0.3.3 #60675

merged 4 commits into from Jul 21, 2019

Conversation

protoben
Copy link

@protoben protoben commented May 1, 2019

Motivation for this change

evcxr is a Rust REPL. It's lacking some features, but it's relatively polished, and it's actively maintained. I'd like to see it in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evcxr: makeWrapper -> nativeBuildInputs and omit Jupyter kernel
8ae2212 
The Jupyter kernel should be its own package. Omitting it and its dependencies here.
@Ma27
Copy link
Member

Ma27 commented Jul 20, 2019

@GrahamcOfBorg build evcxr

@Ma27
evcxr: fix hash and cc access
c4323c2 
The `cargoSha256` hashes across the sourcetree had to be altered after
the last `cargo-vendor` bump. Also ensured that `cc` is available in
`$PATH` to avoid startup errors in the REPL.
@Ma27
Copy link
Member

Ma27 commented Jul 21, 2019

Fixed the cargoSha256 hash that needed to be altered after the last cargo-vendor bump. Also ensured that cc is always available by wrapping the binary.

@GrahamcOfBorg build evcxr

@Ma27
evcxr: fix darwin build
2de35cf 
It seems as the `Security` framework is missing during the linking in a
darwin build environment:

https://logs.nix.ci/?key=nixos/nixpkgs.60675&attempt_id=42d9c159-f1a2-4abc-ab14-9dea23d941b1
@Ma27
Copy link
Member

Ma27 commented Jul 21, 2019

@GrahamcOfBorg build evcxr

@Ma27
Copy link
Member

Ma27 commented Jul 21, 2019

Built and tested locally, appears to work fine, thanks a lot for working on this!

@Ma27 Ma27 merged commit e15bc90 into NixOS:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@protoben @Ma27 @symphorien @Janik-Haag