Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs-11_x: 11.14.0 -> 11.15.0 #60544

Merged
merged 1 commit into from May 1, 2019
Merged

Conversation

angristan
Copy link
Member

@angristan angristan commented Apr 30, 2019

Motivation for this change

Changelog

Things done
stanislas@nixpsla ~/nixpkgs> (nodejs-11_x/v11.15.0|✔) ./result/bin/node -v
v11.15.0
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented May 1, 2019

@GrahamcOfBorg build nodejs-11_x

@marsam marsam merged commit 4a7e6f3 into NixOS:master May 1, 2019
@marsam
Copy link
Contributor

marsam commented May 1, 2019

built and tested locally on darwin and NixOS
@angristan thanks!

@angristan angristan deleted the nodejs-11_x/v11.15.0 branch May 1, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants