Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docui: init at 1.0.3 #60616

Merged
merged 1 commit into from May 1, 2019
Merged

docui: init at 1.0.3 #60616

merged 1 commit into from May 1, 2019

Conversation

eugenezastrogin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit May 1, 2019 10:22
@eugenezastrogin eugenezastrogin mentioned this pull request May 1, 2019
Open
tomberek
tomberek requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we split the addition of a maintainer into a separate commit.

When building:

hash mismatch in fixed-output derivation '/nix/store/fp6qf0zkpdpk4j99pv1fd01zxziww7hv-docui-1.0.3-go-modules':
  wanted: sha256:0qxlrjwngqr1yb29jd5wkd3b9c5igdii9s6cqy3grdz90flfk1av
  got:    sha256:1qma9bnd4k594cr5dcv74xns53mhfyl4jsm01chf85dxywjjd9vd
cannot build derivation '/nix/store/l08nbnn7km4grkl224b5isjxr5abrpj1-docui-1.0.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3hjsjbax7l5f23xbi3jb989d8g5fc1gf-env.drv': 1 dependencies couldn't be built

so check your hashes.

kalbasit
kalbasit requested changes May 1, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @tomberek mentioned, the maintainer should be done in its own commit. Please make sure to rebase over the latest master, as you should be using Go 1.12 to compute the hash. It's different from Go 1.11.

pkgs/tools/misc/docui/default.nix Show resolved Hide resolved
@eugenezastrogin
Copy link
Member Author

Thank you!
I rebased over latest master with Go 1.12 and changed hash accordingly, should build without errors now.
I also removed irrelevant maintainers change.

@kalbasit
Copy link
Member

kalbasit commented May 1, 2019

@GrahamcOfBorg build docui

@ofborg ofborg bot requested a review from kalbasit May 1, 2019 16:51
kalbasit
kalbasit requested changes May 1, 2019
View reviewed changes
pkgs/tools/misc/docui/default.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member

kalbasit commented May 1, 2019

@GrahamcOfBorg build docui

@ofborg ofborg bot requested a review from kalbasit May 1, 2019 19:24
@kalbasit kalbasit merged commit e334a30 into NixOS:master May 1, 2019
@eugenezastrogin eugenezastrogin deleted the docui branch May 1, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek requested changes

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eugenezastrogin @kalbasit @tomberek @Janik-Haag