Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinentry: update patch url #60699

Closed
wants to merge 1 commit into from
Closed

pinentry: update patch url #60699

wants to merge 1 commit into from

Conversation

marenz2569
Copy link
Member

@marenz2569 marenz2569 commented May 2, 2019 •
edited

Motivation for this change

The old url caused a HTTP 404.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel May 2, 2019 01:53
@jtojnar
Copy link
Contributor

jtojnar commented May 2, 2019

Maybe it would be better to get it from salsa.debian.org

@marenz2569 marenz2569 changed the title pinentry: update patch 1.1.0-1 -> 1.1.0-2 pinentry: update patch url May 2, 2019
@marenz2569
Copy link
Member Author

@jtojnar I have changed the url to salsa.debian.org.

jtojnar
jtojnar approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@JohnAZoidberg JohnAZoidberg mentioned this pull request May 2, 2019
Closed
10 tasks
@vcunat
Copy link
Member

vcunat commented May 3, 2019

Almost; see 0b9c477.

@vcunat vcunat closed this May 3, 2019
vcunat added a commit that referenced this pull request May 3, 2019
@vcunat
pinentry: update patch url
918b4e2 
I verified the hash did NOT change as suggested in #60699.

(cherry picked from commit 0b9c477)
vcunat added a commit that referenced this pull request May 3, 2019
@vcunat
pinentry: update patch url
a483713 
I verified the hash did NOT change as suggested in #60699.

(cherry picked from commit 0b9c477)
vcunat added a commit that referenced this pull request May 3, 2019
@vcunat
pinentry: update patch url
0b9c477 
I verified the hash did NOT change as suggested in #60699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marenz2569 @jtojnar @vcunat