Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntfs-3g: remove patch as it been fixed #60697

Merged
merged 2 commits into from May 2, 2019
Merged

ntfs-3g: remove patch as it been fixed #60697

merged 2 commits into from May 2, 2019

Conversation

marenz2569
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is not needed anymore because the CVE reported in release 2016.2.22 has been fixed upstream with release 2017.3.23

@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label May 2, 2019
@marenz2569 marenz2569 changed the title ntfs-3g: fix debian url ntfs-3g: remove patch as it been fixed May 2, 2019
@marenz2569
Copy link
Member Author

@c0bw3b The requested changes have been applied.

@ofborg ofborg bot requested a review from dezgeg May 2, 2019 07:30
@c0bw3b
Copy link
Contributor

c0bw3b commented May 2, 2019

@GrahamcOfBorg build ntfs3g

@c0bw3b c0bw3b self-assigned this May 2, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 2, 2019

Result of nix-review pr 60697

29 package were build:
  • atom (gnome2.gvfs ,woeusb)
  • atom-beta (gnome2.gvfs ,woeusb)
  • cantata (gnome2.gvfs ,woeusb)
  • clementine (gnome2.gvfs ,woeusb)
  • clementineUnfree (gnome2.gvfs ,woeusb)
  • far2l (gnome2.gvfs ,woeusb)
  • gvfs (gnome2.gvfs ,woeusb)
  • gnome3.gnome-control-center (gnome2.gvfs ,woeusb)
  • gnome3.gnome-disk-utility (gnome2.gvfs ,woeusb)
  • gnome3.gvfs (gnome2.gvfs ,woeusb)
  • hal-flash (gnome2.gvfs ,woeusb)
  • ntfs3g (gnome2.gvfs ,woeusb)
  • os-prober (gnome2.gvfs ,woeusb)
  • pam_usb (gnome2.gvfs ,woeusb)
  • partclone (gnome2.gvfs ,woeusb)
  • pmount (gnome2.gvfs ,woeusb)
  • psensor (gnome2.gvfs ,woeusb)
  • rabbitvcs (gnome2.gvfs ,woeusb)
  • rapid-photo-downloader (gnome2.gvfs ,woeusb)
  • spaceFM (gnome2.gvfs ,woeusb)
  • testdisk (gnome2.gvfs ,woeusb)
  • testdisk-photorec (gnome2.gvfs ,woeusb)
  • udiskie (gnome2.gvfs ,woeusb)
  • udisks (gnome2.gvfs ,woeusb)
  • usermount (gnome2.gvfs ,woeusb)
  • wimlib (gnome2.gvfs ,woeusb)
  • winusb (gnome2.gvfs ,woeusb)
  • xfce.gigolo (gnome2.gvfs ,woeusb)
  • xfce.gvfs (gnome2.gvfs ,woeusb)

@c0bw3b c0bw3b merged commit 3e5a0be into NixOS:master May 2, 2019
c0bw3b pushed a commit to c0bw3b/nixpkgs that referenced this pull request May 2, 2019
@marenz2569 @c0bw3b
ntfs3g: remove obsolete CVE-2017-0358 patch
fb3b220 
* ntfs-3g: remove patch as it been fixed  (NixOS#60697)

* ntfs3g: fetchpatch is unused

(cherry picked from commit 3e5a0be)
@c0bw3b c0bw3b mentioned this pull request May 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

@c0bw3b c0bw3b

Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marenz2569 @c0bw3b