Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler_utils: 0.74.0 -> 0.79.0 #60701

Merged
merged 3 commits into from Oct 13, 2019
Merged

poppler_utils: 0.74.0 -> 0.79.0 #60701

merged 3 commits into from Oct 13, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented May 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/poppler-utils/versions.

meta.description for poppler_utils is: '"A PDF rendering library"'.

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

964 total rebuild path(s)

311 package rebuild(s)

311 x86_64-linux rebuild(s)
280 i686-linux rebuild(s)
110 x86_64-darwin rebuild(s)
263 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
R
aesop
apt
apvlv
asciidoc-full
asciidoc-full-with-plugins
asymptote
auctex
autofs5
bookworm
btrbk
calibre
cddlib
cups-filters
dblatex
dblatexFull
deepin.dde-api
deepin.dde-daemon
deepin.dde-session-ui
deepin.deepin-desktop-base
deepin.deepin-desktop-schemas
deepin.deepin-metacity
deepin.deepin-mutter
deepin.deepin-wallpapers
deepin.deepin-wm
deja-dup
denemo
diff-pdf
diffpdf
digikam
disorderfs
dolphin
dragon
dwarf-fortress-packages.dwarf-fortress-full
dwarf-fortress-packages.dwarf-therapist
dwarf-therapist
eaglemode
eclib
elisa
empathy
enblend-enfuse
enlightenment.econnman
enlightenment.efl
enlightenment.enlightenment
enlightenment.ephoto
enlightenment.rage
enlightenment.terminology
epdfview
eukleides
evince

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/2jhpy23fg386zpfxrswwnl2fzak9c0z5-poppler-utils-0.76.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A poppler_utils https://github.com/r-ryantm/nixpkgs/archive/9908cad5c24a6431fa5aac8cfa570452713ea994.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2jhpy23fg386zpfxrswwnl2fzak9c0z5-poppler-utils-0.76.0
ls -la /nix/store/2jhpy23fg386zpfxrswwnl2fzak9c0z5-poppler-utils-0.76.0/bin

cc @ttuegel for testing.

@r-ryantm
poppler_utils: 0.74.0 -> 0.76.0
9908cad 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/poppler-utils/versions
@ofborg ofborg bot requested a review from ttuegel May 2, 2019 02:05
@luzpaz
Copy link
Contributor

luzpaz commented May 2, 2019

poppler 0.76.1 has been released: https://poppler.freedesktop.org/poppler-0.76.1.tar.xz

@jtojnar
Copy link
Contributor

jtojnar commented May 3, 2019 •
edited

@GrahamcOfBorg build cups-filters texlive.bin.core

@c0bw3b c0bw3b changed the title poppler_utils: 0.74.0 -> 0.76.0 poppler_utils: 0.74.0 -> 0.76.1 May 3, 2019
jtojnar
jtojnar requested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks texlive.bin.core.

jtojnar
jtojnar requested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks texlive.bin.core.

@mmahut mmahut changed the title poppler_utils: 0.74.0 -> 0.76.1 poppler_utils: 0.74.0 -> 0.79.0 Aug 10, 2019
@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

@GrahamcOfBorg build cups-filters texlive.bin.core

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

ping @vcunat @veprbl @lovek323 @jwiegley about the texlive.bin failure.

@risicle
Copy link
Contributor

risicle commented Oct 12, 2019

This should be considered a security issue as it resolves CVE-2019-9959

https://nvd.nist.gov/vuln/detail/CVE-2019-9959

Though if it's really troublesome there does seem to be a fairly trivial patch available linked to from https://security-tracker.debian.org/tracker/CVE-2019-9959

This was referenced Oct 12, 2019
Merged
Merged
@ttuegel
Copy link
Member

ttuegel commented Oct 13, 2019

Due to the security implications, I am going to merge this pull request into staging despite the breakage; we can fix that in staging-next. We should merge the patches into master for quicker turnaround.

@ttuegel ttuegel merged commit dd6261c into NixOS:staging Oct 13, 2019
@risicle
Copy link
Contributor

risicle commented Oct 13, 2019

Okaaaaaay, rebasing the patch to master...

@r-ryantm r-ryantm deleted the auto-update/poppler-utils branch October 20, 2019 13:27
@FRidh
Copy link
Member

FRidh commented Oct 20, 2019

There are a bunch of poppler-related failures on staging-next. See e.g. https://hydra.nixos.org/build/103643153.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 20, 2019

That one is caused by race between this and #71046. We should revert this PR, as it is nowhere near ready.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 20, 2019

Or maybe not, this failure has already been resolved in 192e73f.

@FRidh
Copy link
Member

FRidh commented Oct 20, 2019 •
edited

Then there's texlive breaking. I will revert it instead. Seems like texlive is failing anyway.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 20, 2019

Hopefully, #71419 will fix that.

@FRidh
Copy link
Member

FRidh commented Oct 20, 2019

Ah, I forgot to revert all 3 commits. Let's try again.

@FRidh
Copy link
Member

FRidh commented Oct 20, 2019

These changes were reverted in b5e481a. Additionally, the bump to 0.81.0 was reverted in 5118f12.

@FRidh
Copy link
Member

FRidh commented Oct 20, 2019

@ttuegel the patch went in in #71046. or was there anything more relevant in the newer versions of poppler?

@veprbl
Copy link
Member

veprbl commented Oct 20, 2019

I think I can pick up bump to poppler 0.79.0 back in #71419

@jtojnar
Copy link
Contributor

jtojnar commented Oct 20, 2019

@veprbl That would be great. Could you try bumping straight to 0.81.0, if you do that? Also do not forget checking/bumping cups-filters.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
@ttuegel @dtzWill
Merge pull request NixOS#60701 from r-ryantm/auto-update/poppler-utils
2ed4615 
poppler_utils: 0.74.0 -> 0.79.0

(cherry picked from commit dd6261c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
9.needs: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@r-ryantm @luzpaz @jtojnar @mmahut @risicle @ttuegel @FRidh @veprbl @c0bw3b