Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docbook-xsl: update patch #60696

Closed
wants to merge 1 commit into from
Closed

docbook-xsl: update patch #60696

wants to merge 1 commit into from

Conversation

marenz2569
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra May 2, 2019 01:36
@artemist
Copy link
Member

artemist commented May 2, 2019

What is the purpose of this? It would cause a mass-rebuild, and docbook-xsl already builds and works.

@marenz2569
Copy link
Member Author

marenz2569 commented May 2, 2019 •
edited

@artemist Yes it was my fault. I got an HTTP 404, because of other reasons.
The current patch works, I will close this PR.

@marenz2569 marenz2569 closed this May 2, 2019
@marenz2569 marenz2569 deleted the patch-docbook-xsl branch May 2, 2019 04:44
@artemist
Copy link
Member

artemist commented May 2, 2019

Okay, that's good to know. I wanted to make sure it wasn't an error on my end, and the derivation for the patch did seem to build with nix-store --realise --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marenz2569 @artemist