Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mikutter: 3.5.13 -> 3.8.7 #60808

Merged
merged 1 commit into from May 3, 2019
Merged

mikutter: 3.5.13 -> 3.8.7 #60808

merged 1 commit into from May 3, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented May 2, 2019 •
edited

Motivation for this change

Mikutter was quite out of date, marked as broken, and with security issues.
There was another attempt to update it at: #58966 but it didn't actually run.

While this version still raises an exception when trying to actually add a twitter account, I think it's a huge step forward, and the new failure seems to be due to an OAuth issue rather than something caused by the packaging (though not 100% certain).

At least it gives use something to further improve from.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: ruby label May 2, 2019
@manveru manveru mentioned this pull request May 2, 2019
Open
27 tasks
@zimbatm zimbatm merged commit 9a0596e into NixOS:master May 3, 2019
jtojnar
jtojnar reviewed Sep 10, 2019
View reviewed changes
pkgs/applications/networking/instant-messengers/mikutter/default.nix
@@ -54,7 +69,6 @@ stdenv.mkDerivation rec {
'';

meta = with stdenv.lib; {
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this still be marked as broken when you cannot log in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build itself is not broken, and there are no tests for this... For any bugs during usage we can open new issues but it seems like this has no users yet.

@jtojnar jtojnar mentioned this pull request Sep 10, 2019
Closed
10 tasks
@manveru manveru deleted the mikutter-update branch December 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @jtojnar @zimbatm