Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinentry: fix patch url #60810

Closed
wants to merge 1 commit into from
Closed

pinentry: fix patch url #60810

wants to merge 1 commit into from

Conversation

nixbitcoin
Copy link
Contributor

Motivation for this change

Building pinentry fails because URL is 404. I updated URL slightly, it kept same sha256, and that fixed it.

Occured during testing of fort-nix/nix-bitcoin#48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixbitcoin nixbitcoin changed the title Fix broken URL pinentry: fix patch url May 2, 2019
@JohnAZoidberg
Copy link
Member

Sorry #60699 was faster :P

@vcunat vcunat closed this May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: duplicate 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixbitcoin @JohnAZoidberg @vcunat