Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trezor LUKS initrd #60774

Closed
wants to merge 3 commits into from
Closed

Trezor LUKS initrd #60774

wants to merge 3 commits into from

Conversation

petrkr
Copy link

@petrkr petrkr commented May 2, 2019

Motivation for this change

Use TREZOR as root disk encryption option, for this is need trezorencrypt from other PR #58968

Things done

Initial support, tested Trezor One, Trezor T, crash (fallback to passphrase), missing trezor (fallback) or canceled (again fallback).

Not tested: situation with Yubikey combination as I do not own any yubikey

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

petrkr referenced this pull request May 13, 2019
@FRidh
nixos/luksroot: GPG Smartcard support for luks encrypted volumes
147621f
@petrkr petrkr mentioned this pull request May 13, 2019
Merged
10 tasks
@petrkr
Copy link
Author

petrkr commented May 13, 2019

Rebased, to latest master, fixed conflict with newest initrd from PR #60372. Also that luksroot will need refactor since it's littlebit messy by that GPG support. For first it makes collision with YubiKey (have same named methods "open by hardware". But that would be for maintainer of luksroot.nix. I did trezor support which is not breaking support of both now.

@petrkr petrkr closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@petrkr