buck: fix build #60590
Merged
buck: fix build #60590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0bw3b
approved these changes
May 1, 2019
There was a problem hiding this comment.
Local nix-review succeeds
2 package were build:
buck pyreBuild log excerpt
[...]
BUILT 24/1535 JOBS 0.1s //third-party/java/asm:asm-commons
BUILT 25/1535 JOBS 0.1s //third-party/java/j2objc:j2objc-annotations
BUILT 26/1535 JOBS 0.1s //third-party/java/asm:asm-tree
BUILT 27/1535 JOBS 0.1s //third-party/java/asm:asm-util
BUILT 28/1535 JOBS 0.0s //third-party/java/asm:asm-analysis
BUILT 29/1535 JOBS 0.0s //third-party/java/asm:asm-jar
BUILT 30/1535 JOBS 0.1s //third-party/java/plexus:plexus-utils
BUILT 31/1535 JOBS 0.8s //src/com/facebook/buck/features/python:pex
BUILT 32/1535 JOBS 0.2s //third-party/java/asm:asm-tree#class-abi
BUILT 33/1535 JOBS 0.0s //third-party/java/j2objc:j2objc-annotations#class-abi
BUILT 34/1535 JOBS 0.3s //third-party/java/plexus:plexus-utils#class-abi
BUILT 35/1535 JOBS 0.0s //third-party/java/asm:asm-util#class-abi
BUILT 36/1535 JOBS 0.2s //third-party/java/jacoco:report#class-abi
BUILT 37/1535 JOBS 0.1s //third-party/java/asm:asm-jar#class-abi
BUILT 38/1535 JOBS 0.0s //third-party/java/asm:asm-commons#class-abi
[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix buck build https://hydra.nixos.org/build/92918793
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)