Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vala updates #60548

Merged
merged 6 commits into from May 1, 2019
Merged

vala updates #60548

merged 6 commits into from May 1, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

See News in commit msg's.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peterhoeg and jtojnar April 30, 2019 23:01
@jtojnar
Copy link
Contributor

jtojnar commented Apr 30, 2019

Myybe we should merge the Vala part of #60198 first.

@worldofpeace
Copy link
Contributor Author

I'd like to pick 393ca4c here and then it can be dropped from that pr if that sounds reasonable?

@jtojnar
Copy link
Contributor

jtojnar commented May 1, 2019

Other than that 0.42 commit message links to 0.40 news

worldofpeace and others added 2 commits April 30, 2019 21:55
@worldofpeace
vala: no vertical align
2148e70
@JohnAZoidberg @worldofpeace
vala: Prepare for updateScript
cbb8034 
It doesn't have to be that complicated with the major and minor versions
being split. We have library functions that handle it fine.

passthru.upateScript can be enabled once NixOS#59372 is merged
@worldofpeace
Copy link
Contributor Author

Fixed the commit msg. Self merging 😄

@worldofpeace worldofpeace merged commit 018e5ff into NixOS:staging May 1, 2019
@worldofpeace worldofpeace deleted the vala-updates/04-30-19 branch May 1, 2019 01:56
@ofborg ofborg bot requested a review from jtojnar May 1, 2019 01:56
@worldofpeace worldofpeace mentioned this pull request May 1, 2019
Merged
10 tasks
@dtzWill
Copy link
Member

dtzWill commented May 3, 2019

AFAICT vala 0.44.3 on current staging doesn't build, because the graphviz patch fails to apply :(.

@worldofpeace
Copy link
Contributor Author

Fix incoming shortly 👍

@worldofpeace
Copy link
Contributor Author

patch for vala 0.44.3 fixed in 3b481df

it was rejected because https://gitlab.gnome.org/GNOME/vala/commit/911973341ff70d6b6b00ce612d99e0aaf699106d

@dtzWill
Copy link
Member

dtzWill commented May 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @dtzWill @JohnAZoidberg