lua*Packages improvements #60614
Merged
lua*Packages improvements #60614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generator wanted to do various changes in other packages as well, but I didn't commit those.
Test case that should execute without an error:
echo "require('compat53')" | env NIX_PATH=nixpkgs=$(pwd) \
nix-shell --pure -p lua -p lua.pkgs.compat53 --run lua
Test case that should execute without an error:
echo "require('ssl.https')" | env NIX_PATH=nixpkgs=$(pwd) \
nix-shell --pure -p lua -p lua.pkgs.luasec --run lua
One bugfix patch is included - merged upstream but not released yet. knot-resolver wrapper would need to add binaryheap explicitly, so it's migrated to the automatic LUA path discovery instead.
|
@teto might be interested. |
teto
reviewed
May 1, 2019
|
@GrahamcOfBorg build luaPackages.luacyrussasl luaPackages.binaryheap luaPackages.http |
|
Looks fine to me. seems like luacyrussasl doesn't like darwin but hopefully luarocks-nix will translate the supported formats to nix soon so no need to delay this further. feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I put everything inside a single PR, because there are multiple dependencies among the commits. Feel free to review just parts. I can split this later, in case some part is contentious.
Things done
sandboxinnix.confon non-NixOS)usingnix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Some packages newly have runtime dependency on lua interpreter or other lua packages it depends on, but that's probably not considered a regression. Also, the luarocks builder additionally includes some docs, but that's not big.