Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

softether: 4.25 -> 4.29 #60665

Merged
merged 2 commits into from May 2, 2019
Merged

softether: 4.25 -> 4.29 #60665

merged 2 commits into from May 2, 2019

Conversation

rick68
Copy link
Contributor

@rick68 rick68 commented May 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rick68 rick68 mentioned this pull request May 1, 2019
Closed
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 1, 2019

@GrahamcOfBorg build softether_4_29

@c0bw3b c0bw3b self-assigned this May 1, 2019
@c0bw3b
softether_4_29: restrict to x86_64-linux
75618f8 
Does not build on aarch64 because of upstream "-m64" compile flag
@c0bw3b
Copy link
Contributor

c0bw3b commented May 2, 2019

@GrahamcOfBorg build softether_4_29

@c0bw3b c0bw3b merged commit e775587 into NixOS:master May 2, 2019
@rick68 rick68 deleted the softether branch May 2, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rick68 @c0bw3b