Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: set CONFIG_DRM_VMWGFX_FBCON y #60743

Merged
merged 1 commit into from May 4, 2019
Merged

linux: set CONFIG_DRM_VMWGFX_FBCON y #60743

merged 1 commit into from May 4, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented May 2, 2019

Motivation for this change

Fixes #58070, and brings NixOS into line with Ubuntu/Fedora/Arch/etc.

Things done

Tested that all kernels in Nixpkgs that build before this change build after it.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member Author

alyssais commented May 2, 2019 •
edited

Cc: @marler8997 @macalinao @edef1c

@alyssais alyssais changed the base branch from master to staging May 2, 2019 11:11
@alyssais
linux: set CONFIG_DRM_VMWGFX_FBCON y
58d0134 
Fixes NixOS#58070, and brings NixOS
into line with Ubuntu/Fedora/Arch/etc.

Tested that all kernels in Nixpkgs that build before this change build
after it.
@teto
Copy link
Member

teto commented May 2, 2019

having a similar config than other distros is good IMO. Ideally we should put some checks in place #55755

@alyssais alyssais merged commit 8bd018b into NixOS:staging May 4, 2019
@alyssais alyssais deleted the vmsvga branch May 4, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @teto