Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

photon: 1.0.7 -> 1.3.0 #60640

Merged
merged 3 commits into from May 23, 2019
Merged

photon: 1.0.7 -> 1.3.0 #60640

merged 3 commits into from May 23, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented May 1, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux bignaux requested a review from FRidh as a code owner May 1, 2019 13:38
@bignaux
Copy link
Contributor Author

bignaux commented May 1, 2019

@GrahamcOfBorg build photon

flokli
flokli requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make that two commits:

  • pythonPackages.tld: init at 0.9.3
  • pythonPackages.photon: 1.0.7 -> 1.3.0

On the other hand, it might make sense to move photon to all-packages.nix, so photon: 1.0.7 -> 1.3.0 (as it seems to be just an application)

pkgs/development/python-modules/tld/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/photon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/photon/default.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the photon branch 2 times, most recently from 92ea8ae to e4e65b8 Compare May 1, 2019 22:17
@flokli
Copy link
Contributor

flokli commented May 1, 2019

@GrahamcOfBorg build python.pkgs.tld python3.pkgs.tld

@risicle
Copy link
Contributor

risicle commented May 6, 2019

Builds and appears to work for me, non-nixos linux x86_64

@veprbl
Copy link
Member

veprbl commented May 23, 2019

@GrahamcOfBorg build python.pkgs.tld python3.pkgs.tld photon

@veprbl veprbl merged commit 308169a into NixOS:master May 23, 2019
@bignaux bignaux deleted the photon branch May 23, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bignaux @flokli @risicle @veprbl