Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Carton: init at 1.0.34 #60702

Merged
merged 1 commit into from Jun 10, 2019
Merged

perlPackages.Carton: init at 1.0.34 #60702

merged 1 commit into from Jun 10, 2019

Conversation

rissson
Copy link
Member

@rissson rissson commented May 2, 2019 •
edited

Motivation for this change

This is a required tool to install some dependencies for some projects. For example Lstu.

Also, with Carton 1.0.34, the following dependencies were added:

  • CPANCommonIndex 0.010
  • HTTPTinyish 0.15
  • Menlo 1.9019
  • MenloLegacy 1.9022
  • TieHandleOffset 0.004
  • Win32ShellQuote 0.003001
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rissson
Copy link
Member Author

rissson commented May 2, 2019

Please note this is my first contribution and therefore I don't exactly know how to properly run tests for all of this.

@aanderse
Copy link
Member

aanderse commented May 2, 2019 •
edited

@GrahamcOfBorg build perlPackages.Carton perlPackages.CPANCommonIndex perlPackages.HTTPTinyish perlPackages.Menlo perlPackages.MenloLegacy perlPackages.TieHandleOffset perlPackages.Win32ShellQuote
@GrahamcOfBorg build perldevelPackages.Carton perldevelPackages.CPANCommonIndex perldevelPackages.HTTPTinyish perldevelPackages.Menlo perldevelPackages.MenloLegacy perldevelPackages.TieHandleOffset perldevelPackages.Win32ShellQuote

@aanderse
Copy link
Member

aanderse commented May 3, 2019

@volth after banging my head on my keyboard for a while I'm left with the question: are a bunch of the modules in perdevel broken on master currently? For example CPANMetaCheck, TryTiny, URI.

@kalbasit
Copy link
Member

@GrahamcOfBorg build perlPackages.Carton perlPackages.CPANCommonIndex perlPackages.HTTPTinyish perlPackages.Menlo perlPackages.MenloLegacy perlPackages.TieHandleOffset perlPackages.Win32ShellQuote
@GrahamcOfBorg build perldevelPackages.Carton perldevelPackages.CPANCommonIndex perldevelPackages.HTTPTinyish perldevelPackages.Menlo perldevelPackages.MenloLegacy perldevelPackages.TieHandleOffset perldevelPackages.Win32ShellQuote

@kalbasit
Copy link
Member

Got it, thanks @volth! I'll just wait till it hits master first. Please notify @rissson when it's ready so we can rebase and merge.

@aanderse
Copy link
Member

aanderse commented Jun 9, 2019

@kalbasit Did this hit master yet? If so... ping 😄

@kalbasit
Copy link
Member

@volth I still see it failing. Should @rissson rebase over the latest master?

@kalbasit
Copy link
Member

Fair enough!

@kalbasit kalbasit merged commit 144f1c2 into NixOS:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rissson @aanderse @kalbasit