Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux: 2.9 -> 2.9a #60704

Merged
merged 1 commit into from May 3, 2019
Merged

tmux: 2.9 -> 2.9a #60704

merged 1 commit into from May 3, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented May 2, 2019

Motivation for this change

Update tmux to the latest release.
https://github.com/tmux/tmux/releases/tag/2.9a
Changes: https://raw.githubusercontent.com/tmux/tmux/2.9a/CHANGES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz May 2, 2019 02:34
@BenBals
Copy link
Contributor

BenBals commented May 2, 2019

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Linux nixos-beb 4.19.34 Compile glibc without -fstack-protector. #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux
  • executables tested on Linux nixos-beb 4.19.34 Compile glibc without -fstack-protector. #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

@marsam
Copy link
Contributor

marsam commented May 3, 2019

@GrahamcOfBorg build tmux

@marsam marsam merged commit 069aeee into NixOS:master May 3, 2019
@marsam
Copy link
Contributor

marsam commented May 3, 2019

Sorry for the delay. built and tested locally on NixOS and darwin
Thanks!

@xrelkd
Copy link
Contributor Author

xrelkd commented May 4, 2019

@angristan @BenBals @marsam Thank you!

@xrelkd xrelkd deleted the update/tmux branch May 4, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angristan angristan angristan approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @BenBals @marsam @angristan