pythonPackages.asyncssh: 1.15.1 -> 1.16.1, fixing build with some caveats around ec25519 support #60553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eats around ec25519 support asyncssh requires openssl 1.1.x for ec25519 support, but the default cryptography and pyopenssl packages are built against openssl 1.0.x. however, forcing overrides of these using openssl 1.1.x will produce package collisions meaning asyncssh may not be installable in the same environment as most other default python packages. so rather than do that by default, supply an easy route for those who want ec25519 support
|
Hah! I didn't spot that one. A good decision. It didn't occur to me to check staging for fixes - going to have to add that to my checklist... |
|
Looks like you've integrated the Do you think upstream could use |
|
I suspect they want to flex all the muscles of the tests they can. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This "fixes" the build of
asyncsshmostly through bumping the version. The thing that brokeasyncsshwas its move in1.15.1to depending on openssl 1.1.x for its ec25519 support. The defaultcryptographyandpyopensslpackages are of course built with openssl 1.0.x, so this caused test failures.1.16.1added skip-checks to allow the tests to still pass without ec25519 support.But of course this means that the package, built against the default
cryptographyandpyopensslpackages, won't support ec25519, which sucks. But the only way of enabling that support is by using overridden versions of those packages which would of course produce collisions against any packages using the default versions of those dependencies. Which is quite a lot of them.Sooo... I thought it best not to do that by default, settling for supplying an "easy route" for those needing ec25519 support - overriding the
opensslargument with a 1.1.x version should cause all of the required overriding to happen, while in the normal case the.overrides don't end up affecting the output hash and so there should be no duplicate packages produced.Phew. That was a fun evening.
cc @worldofpeace
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)