Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cataclysm-dda{,-git}: bump version #60785

Merged
merged 4 commits into from May 26, 2019
Merged

cataclysm-dda{,-git}: bump version #60785

merged 4 commits into from May 26, 2019

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented May 2, 2019 •
edited

Motivation for this change

Version 0.D was released a while ago.
The git version in nixpkgs seems too old.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mnacamura
Copy link
Contributor Author

Oops 0.D has an error:
Screen Shot 2019-05-03 at 14 41 40
Trying to fix it.

@mnacamura
Copy link
Contributor Author

mnacamura commented May 3, 2019 •
edited

Done. I noticed that fetchFromGitHub is preffered to fetchurl when fetching from GitHub archive. Fixing it.

@mnacamura
Copy link
Contributor Author

Done this time for sure.

@marius851000
Copy link
Contributor

tested with nix-review, able to play the tutorial.

@infinisil infinisil merged commit c6a9902 into NixOS:master May 26, 2019
@bbigras
Copy link
Contributor

bbigras commented Jun 15, 2019

Is it possible to use custom tilesets? The gfx folder seems to be in the read-only nix store. Is it possible by overriding the package? or can the game load tilesets from ~/.local/share/ or something like that?

@mnacamura
Copy link
Contributor Author

Yes. You can package any tileset and use buildEnv or symlinkJoin to wrap C:DDA binary with --datadir argument. Example: https://github.com/mnacamura/nixpkgs-cdda-mods/blob/572e6555dd14abe8bb3bde54234a4a31652c6a44/wrapper.nix#L29

@bbigras
Copy link
Contributor

bbigras commented Jun 15, 2019

Thank you very much.

@mnacamura mnacamura deleted the cdda-updates branch June 17, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnacamura @marius851000 @bbigras @infinisil