Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of classy prelude yesod and esqueleto #60779

Merged
merged 3 commits into from May 4, 2019
Merged

Fix build of classy prelude yesod and esqueleto #60779

merged 3 commits into from May 4, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented May 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub
Copy link
Member Author

pSub commented May 2, 2019

I think those fixes should be applied to master as well. However I haven't looked into the state of the master branch yet.

peti
peti requested changes May 2, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove those packages from the list of broken builds in pkgs/development/haskell-modules/configuration-hackage2nix.yaml. You'll also need to remove the broken = true attributes in hackage-packages.nix. Without those changes, users won't be able to build the fixed packages.

@pSub pSub force-pushed the fix-classy-prelude-yesod-and-esqueleto branch from c40b860 to dfd4724 Compare May 2, 2019 17:50
@pSub pSub force-pushed the fix-classy-prelude-yesod-and-esqueleto branch from dfd4724 to a3bedc4 Compare May 2, 2019 18:14
@pSub
Copy link
Member Author

pSub commented May 2, 2019

Thank you @peti. I've removed the broken attributes from hackage-packages.nix and configuration-hackage2nix.yaml.

@pSub
Copy link
Member Author

pSub commented May 2, 2019

@GrahamcOfBorg build haskellPackages.classy-prelude-yesod
@GrahamcOfBorg build haskellPackages.esqueleto

@pSub pSub requested a review from peti May 2, 2019 18:46
@pSub pSub merged commit a1411ae into release-19.03 May 4, 2019
@pSub pSub deleted the fix-classy-prelude-yesod-and-esqueleto branch May 4, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pSub @peti