Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] Security backport for signing-party #60647

Merged
merged 2 commits into from May 1, 2019
Merged

[19.03] Security backport for signing-party #60647

merged 2 commits into from May 1, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented May 1, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
signing-party: 2.8 -> 2.9
7629cc1 
(cherry picked from commit f1e72ef)
@primeos
signing-party: 2.9 -> 2.10 (security, CVE-2019-11627)
430e814 
I switched to fetchFromGitLab for more transparency and because 2.10 is
not yet available on any Debian mirrors.
A drawback is that any dates in the man pages will now always be
set to 1970-01-01, because fetchFromGitLab removes the timestamps from
$src (not manually but by unpacking the archive).

(cherry picked from commit 3b3a636)
@primeos primeos self-assigned this May 1, 2019
@ofborg ofborg bot requested a review from fpletz May 1, 2019 15:14
@primeos primeos merged commit a07df8e into NixOS:release-19.03 May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees

@primeos primeos

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos