Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] nixos/modules/networking/wg-quick Add wg-quick options support #60648

Closed
wants to merge 1 commit into from

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented May 1, 2019

Backport wg-quick module from #53043.

This is an implementation of wireguard support using wg-quick config
generation.

This seems preferrable to the existing wireguard support because
it handles many more routing and resolvconf edge cases than the
current wireguard support.

It also includes work-arounds to make key files work.

This has one quirk:
We need to set reverse path checking in the firewall to false because
it interferes with the way wg-quick sets up its routing.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is an implementation of wireguard support using wg-quick config
generation.

This seems preferrable to the existing wireguard support because
it handles many more routing and resolvconf edge cases than the
current wireguard support.

It also includes work-arounds to make key files work.

This has one quirk:
We need to set reverse path checking in the firewall to false because
it interferes with the way wg-quick sets up its routing.
@asymmetric asymmetric requested a review from infinisil as a code owner May 1, 2019 14:59
@worldofpeace worldofpeace changed the title nixos/modules/networking/wg-quick Add wg-quick options support [19.03] nixos/modules/networking/wg-quick Add wg-quick options support May 1, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 1, 2019

Enabling this module changes the firewall behaviour silently.
That's not ideal in general, and worse to backport since it would change the default and expected behaviour of a stable release.

@asymmetric
Copy link
Contributor Author

Agreed, let's close this.

@asymmetric asymmetric closed this May 5, 2019
@asymmetric asymmetric deleted the backport-wg-quick branch May 5, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants