Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.reportlab: 3.5.19 -> 3.5.20 #60605

Merged
merged 1 commit into from May 2, 2019
Merged

pythonPackages.reportlab: 3.5.19 -> 3.5.20 #60605

merged 1 commit into from May 2, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented May 1, 2019 •
edited by veprbl

Motivation for this change

reportlab currently fails to build (at least on my system) due to test that requires network access to download an image file (which is necessary for the hplip printer driver). This change updates reportlab to version 3.5.20, while also disabling the spurious test.

Also verified that hplip builds.

Resolves: #60791

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
pythonPackages.reportlab: 3.5.13 -> 3.5.20
e62cc0c 
Also disable an additional test that requires network access to download
an image.
@danieldk danieldk requested a review from FRidh as a code owner May 1, 2019 08:41
@danieldk
Copy link
Contributor Author

danieldk commented May 1, 2019

@GrahamcOfBorg build python2Packages.reportlab python3Packages.reportlab hplip

@veprbl veprbl merged commit 626fe1a into NixOS:master May 2, 2019
@veprbl veprbl changed the title pythonPackages.reportlab: 3.5.13 -> 3.5.20 pythonPackages.reportlab: 3.5.19 -> 3.5.20 May 2, 2019
@danieldk danieldk deleted the reportlab-3.5.20 branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IOError: Cannot open resource "http://www.reportlab.com/rsrc/encryption.gif"
2 participants
@danieldk @veprbl