Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.io: replace TSTriple with triple_layout(). #56

Closed
wants to merge 1 commit into from
Closed

lib.io: replace TSTriple with triple_layout(). #56

wants to merge 1 commit into from

Conversation

jfng
Copy link
Contributor

@jfng jfng commented Apr 4, 2019

No description provided.

whitequark
whitequark reviewed Apr 4, 2019
View reviewed changes
nmigen/lib/io.py Outdated
("oe", 1, DIR_FANOUT),
("i", shape, DIR_FANIN)
]
super().__init__(fields)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be just a function def TripleLayout, since subclassing adds no value here.

@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited

Codecov Report

Merging #56 into master will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   85.51%   85.49%   -0.02%     
==========================================
  Files          27       27              
  Lines        3914     3916       +2     
  Branches      765      765              
==========================================
+ Hits         3347     3348       +1     
- Misses        478      479       +1     
  Partials       89       89
Impacted Files Coverage Δ
nmigen/compat/fhdl/specials.py 35% <50%> (+0.27%) ⬆️
nmigen/lib/io.py 40% <66.66%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74cacd...96ce4d0. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 56.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          27       27           
  Lines        3914     3914           
  Branches      765      765           
=======================================
  Hits         3347     3347           
  Misses        478      478           
  Partials       89       89
Impacted Files Coverage Δ
nmigen/compat/fhdl/specials.py 35% <50%> (+0.27%) ⬆️
nmigen/lib/io.py 38.88% <75%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74cacd...96ce4d0. Read the comment docs.

@jfng jfng changed the title lib.io: replace TSTriple with TripleLayout. lib.io: replace TSTriple with triple_layout(). Apr 4, 2019
@whitequark
Copy link
Contributor

This PR has been superseded by the pin_layout implementation.

@whitequark whitequark closed this May 1, 2019
@jfng jfng deleted the remove-tstriple branch September 30, 2019 18:45
@nmigen-issue-migration nmigen-issue-migration mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfng @whitequark