Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 11.9.8 -> 11.9.11 #60637

Merged
merged 3 commits into from May 1, 2019
Merged

gitlab: 11.9.8 -> 11.9.11 #60637

merged 3 commits into from May 1, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels May 1, 2019
@flokli flokli requested review from fpletz and globin May 1, 2019 12:53
@flokli
Copy link
Contributor Author

flokli commented May 1, 2019

@GrahamcOfBorg test gitlab

@globin
Copy link
Member

globin commented May 1, 2019

@GrahamcOfBorg test gitlab

@globin globin merged commit d9876f6 into NixOS:master May 1, 2019
@flokli flokli deleted the gitlab-11.9.11 branch May 1, 2019 20:57
@flokli
Copy link
Contributor Author

flokli commented May 1, 2019

@globin thanks! Will you take care of the backport, too?

@globin
Copy link
Member

globin commented May 1, 2019

done

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants