Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: 1.18.1 -> 1.18.2 #60792

Merged
merged 1 commit into from May 3, 2019
Merged

rustup: 1.18.1 -> 1.18.2 #60792

merged 1 commit into from May 3, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented May 2, 2019

Motivation for this change

Update rustup to the latest release.
https://github.com/rust-lang/rustup.rs/releases/tag/1.18.2
Changes: https://github.com/rust-lang/rustup.rs/blob/1.18.2/CHANGELOG.md

cc maintainer @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented May 3, 2019

@GrahamcOfBorg build rustup

@marsam
Copy link
Contributor

marsam commented May 3, 2019

@GrahamcOfBorg build rustup

@marsam marsam merged commit cdf2347 into NixOS:master May 3, 2019
@marsam
Copy link
Contributor

marsam commented May 3, 2019

I've added a fix for the darwin build, I hope you don't mind.
Built and tested locally on NixOS and darwin.
@xrelkd thanks!

@xrelkd
Copy link
Contributor Author

xrelkd commented May 3, 2019

@marsam Thanks for adding the fix for darwin build and merging this PR.

@xrelkd xrelkd deleted the update/rustup branch May 3, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants