Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox-cli: Fix and add Nautilus extension #60752

Merged
merged 1 commit into from May 2, 2019
Merged

dropbox-cli: Fix and add Nautilus extension #60752

merged 1 commit into from May 2, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 2, 2019

…since this is actually dropbox-nautilus project.

In one of the previous updates, the source code responsible for finding dropboxd
was changed, rendering our sed replacement not working. That triggered the installer
which in turn failed on the unavailability of gobject-introspection typelibs. And
when that was fixed, we got bitten by our lazy packaging putting a broken code
into the installer.

This is a proper fix for all the issues, except for making typelibs available to
the installer since we shall use Nix instead.

Fixes: #60714

cc @mnacamura

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
dropbox-cli: Fix and add Nautilus extension
dd0c105 
…since this is actually dropbox-nautilus project.

In one of the previous updates, the source code responsible for finding dropboxd
was changed, rendering our sed replacement not working. That triggered the installer
which in turn failed on the unavailability of gobject-introspection typelibs. And
when that was fixed, we got bitten by our lazy packaging putting a broken code
into the installer.

This is a proper fix for all the issues, except for making typelibs available to
the installer since we shall use Nix instead.
@ofborg ofborg bot requested a review from the-kenny May 2, 2019 12:07
@mnacamura
Copy link
Contributor

Runs fine for me. Thanks!

@jtojnar
Copy link
Contributor Author

jtojnar commented May 2, 2019

We might also want to remove the broken --install flag completely.

@jtojnar
Copy link
Contributor Author

jtojnar commented May 2, 2019

Hmm, dropboxd will still try to download something. Let’s merge it as is.

@jtojnar jtojnar merged commit 00f52f0 into NixOS:master May 2, 2019
@jtojnar jtojnar deleted the dropbox-cli branch May 2, 2019 23:02
@jtojnar jtojnar mentioned this pull request Jun 4, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/using-dropbox-on-nixos/387/17

@jtojnar jtojnar mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dropbox-cli: No module named 'gi'
3 participants
@jtojnar @mnacamura @nixos-discourse