Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openocd: update libftdi dependency, fix Darwin build #60623

Merged
merged 1 commit into from May 1, 2019
Merged

openocd: update libftdi dependency, fix Darwin build #60623

merged 1 commit into from May 1, 2019

Conversation

thefloweringash
Copy link
Member

Restrict Linux-only features to Linux and disable any feature that
doesn't build on Darwin for any reason.

Restrict GCC-specific cflags to GCC.

Motivation for this change

Build on Darwin. Note this includes an upgrade in dependency from libftdi 0.20 to libftdi 1.4. I don't have the hardware to test this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash
openocd: update libftdi dependency, fix Darwin build
921a869 
Restrict Linux-only features to Linux and disable any feature that
doesn't build on Darwin for any reason.

Restrict GCC-specific cflags to GCC.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels May 1, 2019
@ofborg ofborg bot requested a review from bjornfor May 1, 2019 11:05
@bjornfor bjornfor merged commit 8e2ab5d into NixOS:master May 1, 2019
@thefloweringash thefloweringash deleted the openocd-darwin branch May 1, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thefloweringash @bjornfor