Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive.bin.core-big: fix build #60628

Merged
merged 1 commit into from May 1, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 1, 2019

metafont requires libX11

Motivation for this change

metafont requires libX11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 1, 2019
@marsam
Copy link
Contributor Author

marsam commented May 1, 2019

@GrahamcOfBorg build texlive.bin.core-big

@gebner
Copy link
Member

gebner commented May 1, 2019

texlive.bin.core-big build just fine for me (on NixOS). Is this is a darwin fix?

@vcunat
Copy link
Member

vcunat commented May 1, 2019

Yes, Hydra shows recent breakage on Darwin only.
@GrahamcOfBorg build texlive.bin.core-big

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, on Linux it was in runtime closure already.

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label May 1, 2019
@c0bw3b c0bw3b merged commit 2c6ecba into NixOS:master May 1, 2019
@marsam marsam deleted the fix-build-texlive.bin.core-big branch May 1, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants