New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rambox: 0.6.6 -> 0.6.7 #60769
rambox: 0.6.6 -> 0.6.7 #60769
Conversation
@GrahamcOfBorg build rambox |
Doesn't build for me:
|
Sorry, this was my first attempt at a contribution to nixpkgs, I'm still trying to figure out exactly how one tests a change like this locally. I suspect there is another sha256 that needs to be updated - I'll take another stab at it - thanks for posting the command you ran! |
You ticked the boxes for building it locally and testing the binaries - (how) did you do that?
Yeah, you correctly updated the Then you can do (from the top level of the nixpkgs repo):
Seems to run fine for me, when I update the other hash, too :) |
I was following the guide here https://nixos.wiki/wiki/Nixpkgs - I believe I did run I rebased my branch on master, and am trying to build again with I've tried Is there any easy way to force it to rebuild the package from scratch? Or run the build without using cached artifacts? I've searched the Nix wiki and google a bit for answers, but I'm not clear on what to do. Thank you for any help! |
@JohnAZoidberg - I updated the other sha256, and when I re-ran |
Yep, this worked. Hmmm, really weird that you could build it before changing the hash. Yup, works like this! The app launches. I trust that you checked whether it actually does the right thing. Usually you can do So what you can do is:
|
Ok, got it - thank you for taking the time to write down this info - I really appreciate it! |
You're welcome! By the way: If you're on NixOS later than 18.09 you have sandboxing enabled. And if not, you can enable it very easyily: https://youtu.be/ULqoCjANK-I?t=550 (first PR tickbox). |
tested with nix-review, started and added a whatsapp account. |
Motivation for this change
Patch update to rambox messaging app.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)