New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emby: Drop package and module and refer to jellyfin #60630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as everybody else involved is happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems here. We're inclined to maintain things that we feasibly can.
Though I think for people switching that we should link to their docs
about database migration (or in general) as migration isn't really possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that Emby has paid features which differentiate it from Jellyfin. It is possible that some of our users are Emby customers and want to remain that way.
I support removing Emby from master because the new proprietary version of Emby would require a new package and maintainer. I don't see anyone volunteering to do so. IF someone wants to package and maintain the new proprietary Emby then they are free to do so in a follow up PR.
Always better to promote free software alternatives 👍
@worldofpeace I've added that link to the release notes as well |
Thanks @etu |
Motivation for this change
This is a followup from #54833 where it was suggested to drop emby in favor of jellyfin.
This fixes #54833
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)