Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emby: Drop package and module and refer to jellyfin #60630

Merged
merged 1 commit into from May 3, 2019
Merged

Conversation

etu
Copy link
Contributor

@etu etu commented May 1, 2019

Motivation for this change

This is a followup from #54833 where it was suggested to drop emby in favor of jellyfin.

This fixes #54833

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from infinisil as a code owner May 1, 2019 11:23
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as everybody else involved is happy.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems here. We're inclined to maintain things that we feasibly can.

Though I think for people switching that we should link to their docs
about database migration (or in general) as migration isn't really possible.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that Emby has paid features which differentiate it from Jellyfin. It is possible that some of our users are Emby customers and want to remain that way.

I support removing Emby from master because the new proprietary version of Emby would require a new package and maintainer. I don't see anyone volunteering to do so. IF someone wants to package and maintain the new proprietary Emby then they are free to do so in a follow up PR.

Always better to promote free software alternatives 👍

@etu
Copy link
Contributor Author

etu commented May 1, 2019

@worldofpeace I've added that link to the release notes as well

@worldofpeace
Copy link
Contributor

Thanks @etu

The change to the manual looks like this rendered
Screenshot from 2019-05-01 11 59 06

@etu etu merged commit 6698c37 into NixOS:master May 3, 2019
@etu etu deleted the drop-emby branch May 3, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants