Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: backport hunspell 1.7.0 support from upstream #60558

Merged
merged 1 commit into from May 3, 2019
Merged

emacs: backport hunspell 1.7.0 support from upstream #60558

merged 1 commit into from May 3, 2019

Conversation

benley
Copy link
Member

@benley benley commented May 1, 2019

Motivation for this change

Backport of #57237

NixOS 19.03 has hunspell 1.7.0 which is incompatible with emacs 26.1.
This issue has been fixed in upstream and we should drop this patch
after emacs is updated too.

(cherry picked from commit 4952378)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley
emacs: backport hunspell 1.7.0 support from upstream
d8b0841 
NixOS 19.03 has hunspell 1.7.0 which is incompatible with emacs 26.1.
This issue has been fixed in upstream and we should drop this patch
after emacs is updated too.

(cherry picked from commit 4952378)
@ofborg ofborg bot added the 6.topic: emacs label May 1, 2019
@ofborg ofborg bot requested review from the-kenny, jwiegley, peti and lovek323 May 1, 2019 01:14
@benley benley merged commit 1ec4af1 into NixOS:release-19.03 May 3, 2019
@benley benley deleted the backport-57237 branch May 3, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@jwiegley jwiegley Awaiting requested review from jwiegley

@peti peti Awaiting requested review from peti

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benley