Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gitea: 1.7.6 -> 1.8.0 #60658

Merged
merged 2 commits into from May 3, 2019
Merged

[19.03] gitea: 1.7.6 -> 1.8.0 #60658

merged 2 commits into from May 3, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented May 1, 2019

Motivation for this change

Backport of #60014 and #60197.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from infinisil as a code owner May 1, 2019 17:43
@etu
Copy link
Contributor Author

etu commented May 1, 2019

@GrahamcOfBorg build gitea nixosTests.gitea

@etu etu requested review from aanderse, srhb and disassembler May 1, 2019 17:44
aanderse
aanderse approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @etu ❤️

@etu

This comment has been minimized.

Sign in to view
@etu etu force-pushed the backport-gitea-updates branch from 1d0dde5 to ff6cdb5 Compare May 1, 2019 20:59
@etu etu merged commit c2c4ff8 into NixOS:release-19.03 May 3, 2019
@etu etu deleted the backport-gitea-updates branch May 3, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@srhb srhb Awaiting requested review from srhb

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @aanderse