Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixops: 1.6.1 -> 1.7 #59776

Merged
merged 2 commits into from Apr 17, 2019
Merged

nixops: 1.6.1 -> 1.7 #59776

merged 2 commits into from Apr 17, 2019

Conversation

AmineChikhaoui
Copy link
Member

@AmineChikhaoui AmineChikhaoui commented Apr 17, 2019 •
edited

Add release 1.7, also keep version 1.6.1 available for Azure
backend users. Azure backend was disabled in v1.7 due to the
python API changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AmineChikhaoui
nixops: 1.6.1 -> 1.7
0db54f9 
Add release 1.7, also keep version 1.6.1 available for Azure
backend users. Azure backend was disabled in v1.7 due to the
python API changes.
@AmineChikhaoui
Copy link
Member Author

@GrahamcOfBorg build nixops_1_6_1

@AmineChikhaoui AmineChikhaoui marked this pull request as ready for review April 17, 2019 15:11
@AmineChikhaoui
Copy link
Member Author

This will need a backport to 19.03 once merged

@grahamc grahamc merged commit 0b37215 into NixOS:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@rbvermaa rbvermaa Awaiting requested review from rbvermaa

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AmineChikhaoui @edolstra @grahamc @GrahamcOfBorg