Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lz4: 1.8.3 -> 1.9.1 #59812

Merged
merged 2 commits into from Apr 27, 2019
Merged

lz4: 1.8.3 -> 1.9.1 #59812

merged 2 commits into from Apr 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 18, 2019

Motivation for this change

https://github.com/lz4/lz4/releases/tag/v1.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Warning : this version has a known bug in the decompression function which makes it read too many bytes. A fix is ongoing. Suggest waiting for v1.9.1.

We should probably wait for v1.9.1 too, right?

@dtzWill
Copy link
Member Author

dtzWill commented Apr 22, 2019 via email

@dtzWill
lz4: 1.9.0 -> 1.9.1
bd361bc 
fixes read out-of-bounds issue w/1.9.0
@dtzWill dtzWill changed the title lz4: 1.8.3 -> 1.9.0 lz4: 1.8.3 -> 1.9.1 Apr 24, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Apr 24, 2019

1.9.1 ! 🎆

@c00w
Copy link
Contributor

c00w commented Apr 25, 2019

Want to rekick the darwin build? Looks like it failed.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

@GrahamcOfBorg build lz4

@FRidh FRidh merged commit 9d36a79 into NixOS:staging Apr 27, 2019
@matthewbauer
Copy link
Member

It looks like this is hitting an issue in staging-next:

https://hydra.nixos.org/build/92960188/

@FRidh
Copy link
Member

FRidh commented May 3, 2019

Indeed, failing for Darwin. Does not seem to be blocking, or is it?

@dtzWill dtzWill mentioned this pull request May 3, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @infinisil @c00w @matthewbauer @FRidh @GrahamcOfBorg