Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidndk-pkgs: Remove -mfloat flag #59743

Merged
merged 1 commit into from Apr 16, 2019
Merged

androidndk-pkgs: Remove -mfloat flag #59743

merged 1 commit into from Apr 16, 2019
+0 −2

Conversation

kmicklas
Copy link
Contributor

Motivation for this change

This flag doesn't actually exist. This is basically a forward-port of #58828 now that #59253 has been merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit d96a566 into NixOS:master Apr 16, 2019
@Ericson2314 Ericson2314 deleted the km-remove-androidndk-mfloat-flag branch April 16, 2019 23:04
@kmicklas kmicklas mentioned this pull request May 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmicklas @matthewbauer @GrahamcOfBorg