Don't permit setting SameSite cookies from cross-site contexts.
#16371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1534237
branch
from
28769b8
to
c6e0fe7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1534237
branch
4 times, most recently
from
af4462a
to
d0b993e
Compare
This is almost entirely based on Mike West's preliminary version: https://chromium-review.googlesource.com/c/chromium/src/+/1528244 The new enforcement blocks the setup portion of some existing WPT tests, which verified read behavior, so the helper they use was changed to always set them in a same-site context by PostMessage'ing to a helper window. Bug: 837412 Change-Id: Iba95d65ec4d0916fb4dfa581efaede50654792d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534237 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#653228}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1534237
branch
from
d0b993e
to
f659164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost entirely based on Mike West's preliminary version:
https://chromium-review.googlesource.com/c/chromium/src/+/1528244
The new enforcement blocks the setup portion of some existing WPT tests,
which verified read behavior, so the helper they use was changed to always
set them in a same-site context by PostMessage'ing to a helper window.
Bug: 837412
Change-Id: Iba95d65ec4d0916fb4dfa581efaede50654792d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534237
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653228}