Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus-packages.mozc: pin to protobuf 3.6 (fixes build breakage at HEAD) #59662

Merged
merged 1 commit into from Apr 16, 2019
Merged

ibus-packages.mozc: pin to protobuf 3.6 (fixes build breakage at HEAD) #59662

merged 1 commit into from Apr 16, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Apr 16, 2019

Motivation for this change

google/mozc#460

mozc currently doesn't build on trunk: https://hydra.nixos.org/build/92239027

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Apr 16, 2019

cc @7c6f434c did I see you making changes relevant to this?

@7c6f434c
Copy link
Member

I fixed a similar but different problem: protobufc has unreleased upstream fix for a different protobuf API change.

@grahamc
Copy link
Member

grahamc commented Apr 16, 2019

@GrahamcOfBorg build ibus-packages.mozc

@grahamc
Copy link
Member

grahamc commented Apr 16, 2019

turns out it is called:

@GrahamcOfBorg build ibus-engines.mozc

@grahamc grahamc merged commit 3beec4a into NixOS:master Apr 16, 2019
@delroth
Copy link
Contributor Author

delroth commented Apr 16, 2019

Thank you! 👍

@Arfrever
Copy link

Arfrever commented Apr 20, 2019 •
edited

Motivation for this change

google/mozc#460

This would be relevant with Protobuf 3.7.0, but not with Protobuf 3.7.1.

https://github.com/protocolbuffers/protobuf/releases/tag/v3.7.1 says:

Avoid marking generated C++ messages as final, though we will do this in a future release

I do not use NixOS, but in Gentoo I have successfully built Mozc with Protobuf 3.7.1.
In https://github.com/NixOS/nixpkgs/blob/985b9e47b8f4e96fcf4dc691e69e7813827b7ee5/pkgs/development/libraries/protobuf/3.7.nix I see:

 version = "3.7.0";

If you update it to 3.7.1, then it should also work...

dywedir pushed a commit to dywedir/nixpkgs that referenced this pull request Apr 22, 2019
@gebner
fcitx-engines.mozc: pin to protobuf 3.6
9458ddb 
See NixOS#59662
c0bw3b pushed a commit to c0bw3b/nixpkgs that referenced this pull request Apr 22, 2019
@gebner @c0bw3b
fcitx-engines.mozc: pin to protobuf 3.6
f203afe 
See NixOS#59662
@teto teto mentioned this pull request Apr 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@delroth @grahamc @7c6f434c @Arfrever @GrahamcOfBorg